Repository navigation
guides: a guide folds and unfolds, and stays as left - #628
Merged
Merged
Conversation
A tree branch is drawn as it is asked to be each frame and toggles itself to match, and the guides view asked for "open if first" every frame: the first guide reopened the moment it was folded, and the last, unfolded, folded and unfolded again without end. The view now remembers each guide as the person left it, by name, as the settings and keybind trees do; a guide never touched is open if it is the first. Part of fizzyedit/plans#30. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The map of unfolded guides was allocated from host.allocator and never freed, so the verdict run's debug allocator reported a leak at exit. The plugin now has a deinit that frees it. The map is written only when a guide's fold changes, not every frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fizzyedit/plans#30. Fixes the tree from #619.
What changes
TreeWidget's branch is drawn the way it is asked to be each frame: when the.expandedit's given differs from its own state, it toggles to match. The settings and keybind trees keep each branch's open state themselves and pass that back. The guides view passed "open if it's the first guide" every frame, so:The view now remembers each guide as the person left it, keyed by a hash of its name. A guide never touched is open if it's the first.
SDK impact
Verified
zig build,zig build check-web,scripts/check-fmt.sh.🤖 Generated with Claude Code